Domain suggestions: Networking and Yosemite layers #8060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
Collaborator
You can test the changes from this Pull Request by:
|
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8045
Description
Domain selection is one of the steps in the store creation flow, and we only support free domains for now due to their incompatibility with IAP. I named the function and struct with "free" in them like
loadFreeDomainSuggestionsandFreeDomainSuggestion, because we might support paid domains in store settings in a later milestone. This PR includes both Networking and Yosemite changes since there's only one endpoint and action.Testing instructions
Just CI for now. In the next PR, some basic UI will be integrated for testing.
RELEASE-NOTES.txtif necessary.